Configuration drivern workflow implemented#26
Merged
Conversation
…omputational_toolkit into ConfDrivenWorkflow
Update server for better start and stop.
Merged with main branch
Conflicts are solved. Minor bugs solved.
gituser789
requested changes
Apr 10, 2025
Contributor
gituser789
left a comment
gituser789
left a comment
There was a problem hiding this comment.
Thx for this PR.
Even after starting the review on the same day, it was not possible to finish it due to the high amount of changes. The first part with integrating the existing pareto summary into the toml file configuration was laying around for couple of days/weeks before checking in, now server code is in the same PR. In future, we should think about how to make smaller pieces to review.
…quest. One update is missing: Last line in summary_processing.py is still comment out. (# df_wo_hs....)
gituser789
requested changes
Apr 11, 2025
Contributor
gituser789
left a comment
gituser789
left a comment
There was a problem hiding this comment.
changes requested as in the comments
Solve the special case bug by replacing the enable_delete_study out of the optimizer function to the flow control. This was necessary because different dependencies of the studys. (e.g. if circuit study is deleted also inductor and transformer studyn needs to be deleted too.)
Replace hardcoded folder names by subdirectory Update variable name for thermal resistance per unit area and comment it is suitable way Fix the heat_sink variable.
gituser789
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According 4 aconfiguration controlled workflow is implemented.
Requirements are available.
Minor issues are still to solve.
[x] Initial implementation of the configuration diven workflow
[ ] Debug special situation (new circuit optimization while results are available