Updated gem-elecrtric-motor with gem-control docs#281
Merged
Conversation
bhk11
requested changes
Jun 2, 2025
Member
bhk11
left a comment
bhk11
left a comment
There was a problem hiding this comment.
I have two changes requests to the current state of the work:
-
could you please change the structure a bit I would prefer to rename the parts folder to parts_gem and create a new folder for gem control e.g. parts_gc.
I know it will some work to change all the paths in .rst files and also the addition of the content into docs/index.rst is missing. -
Please don't mix your work in this branch with the work of the other work package.
… into sphinx_conroldoc (Rebase) # Conflicts: # docs/parts_gem/physical_systems/electric_motors/electric_motor.rst # docs/parts_gem/physical_systems/electric_motors/sixphase_base.rst # docs/parts_gem/physical_systems/electric_motors/sixphase_pmsm.rst
bhk11
requested changes
Jun 17, 2025
Member
bhk11
left a comment
bhk11
left a comment
There was a problem hiding this comment.
I guess there wassome files from the newest nightly commit missing. Can you please have another check into the doc files?
There are some files in the parts folder, which were not in the commit you used for the new doc design.
…ctric-motor into sphinx_conroldoc
…ctric-motor into sphinx_conroldoc
…_controllers.rst to generate at least the html page.
…e in the gem_controllers.rst
bhk11
requested changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Gem-control-docs to Gem-electric-motor - Sphinx documentation