-
Notifications
You must be signed in to change notification settings - Fork 11
fix: add .value to configRef #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe recent changes enhance the handling of the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- examples/vue-uploader/src/components/FileUploader/FileUploader.composition.vue (2 hunks)
Additional comments not posted (2)
examples/vue-uploader/src/components/FileUploader/FileUploader.composition.vue (2)
77-77
: LGTM! Proper use of.value
withconfigRef
.The change correctly utilizes
.value
to handle reactive references in Vue 3, ensuring thatlocaleDefinitionOverride
is updated properly.
103-103
: LGTM! Proper cleanup of reactive reference.Setting
configRef.value.localeDefinitionOverride
tonull
during unmounting ensures that the reactive reference is properly cleaned up.
Description
add .value to configRef in vue composition api example
Checklist
Summary by CodeRabbit
localeDefinitionOverride
.