[WIP][Feature] multi network local config #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's here
This changeset deprecates the global mutable
Networksobject in favor of locally configuredMultiNetworkConfiginstance(s)Local configurations are potentially lighter-weight and don't overwrite each other.
Future versions will completely remove the default infura URLs as well, and local configurations will be a necessity then.
Also, this paves the way to non-JsonRPC based ethereum providers and to true multi-platform.
A an added bonus, the default
MultiNetworkConfigallows networks to be indexed both bynetworkIDand byname.Testing
Methods have been added to check all known paths of interaction with the multi-network configuration holders.
The deprecated
Networksobject now implements that same interface and all existing tests have been kept.