DX-1821: Deprecate Llms #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CahidArda
force-pushed
the
DX-1821-deprecate-llms
branch
from
5fc5473 to
493b571
Compare
mdumandag
reviewed
Apr 17, 2025
|
I think there is a model-provider mismatch here, same for async test: |
yunusemreozdemir
approved these changes
Apr 18, 2025
mdumandag
reviewed
Apr 18, 2025
README.md
Outdated
| ```python | ||
| from qstash import QStash | ||
| from qstash.chat import upstash | ||
| from qstash.chat import openai |
There was a problem hiding this comment.
now, there is a duplicate example. see the line 103, Publish a JSON message to LLM Using Custom Providers
we should remove this or that
|
Apart from this PR, I think we have renamed events to logs in JS SDK, we can make the same here and remove the events api altogether since this is a major version bump |
mdumandag
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.