Mapping trajectory#239
Open
mehradans92 wants to merge 63 commits into
Open
Conversation
|
Hello @mehradans92! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-09-03 17:43:34 UTC |
whitead
requested changes
Sep 1, 2020
Collaborator
whitead
left a comment
whitead
left a comment
There was a problem hiding this comment.
Could you add 1-2 unit tests from your notebook into test_utils.py? This will help make it clear how it should work and prevent us from breaking as development continues.
…ion, fixed import mda importing
whitead
requested changes
Sep 21, 2020
Collaborator
whitead
left a comment
whitead
left a comment
There was a problem hiding this comment.
There appears to be errors in the jupyter notebook. Otherwise, tests and code looks good.
| { | ||
| "ename": "ValueError", | ||
| "evalue": "in user code:\n\n /home/mgholiza/.conda/envs/hoomd-tf2/lib/python3.7/site-packages/tensorflow/python/keras/engine/training.py:806 train_function *\n return step_function(self, iterator)\n /home/mgholiza/.conda/envs/hoomd-tf2/lib/python3.7/site-packages/hoomd/htf/simmodel.py:116 call *\n out = self.compute(*inputs[:self._arg_count])\n /home/mgholiza/.conda/envs/hoomd-tf2/lib/python3.7/site-packages/tensorflow/python/eager/def_function.py:780 __call__ **\n result = self._call(*args, **kwds)\n /home/mgholiza/.conda/envs/hoomd-tf2/lib/python3.7/site-packages/tensorflow/python/eager/def_function.py:814 _call\n results = self._stateful_fn(*args, **kwds)\n /home/mgholiza/.conda/envs/hoomd-tf2/lib/python3.7/site-packages/tensorflow/python/eager/function.py:2828 __call__\n graph_function, args, kwargs = self._maybe_define_function(args, kwargs)\n /home/mgholiza/.conda/envs/hoomd-tf2/lib/python3.7/site-packages/tensorflow/python/eager/function.py:3171 _maybe_define_function\n *args, **kwargs)\n /home/mgholiza/.conda/envs/hoomd-tf2/lib/python3.7/site-packages/tensorflow/python/eager/function.py:2622 canonicalize_function_inputs\n self._flat_input_signature)\n /home/mgholiza/.conda/envs/hoomd-tf2/lib/python3.7/site-packages/tensorflow/python/eager/function.py:2713 _convert_inputs_to_signature\n format_error_message(inputs, input_signature))\n\n ValueError: Python inputs incompatible with input_signature:\n inputs: (\n Tensor(\"IteratorGetNext:0\", shape=(160, 3), dtype=float32),\n Tensor(\"IteratorGetNext:1\", shape=(160, 128, 4), dtype=float32),\n Tensor(\"IteratorGetNext:2\", shape=(3, 3), dtype=float32),\n Tensor(\"IteratorGetNext:3\", shape=(), dtype=float32))\n input_signature: (\n TensorSpec(shape=(None, 128, 4), dtype=tf.float32, name=None),\n TensorSpec(shape=(None, 4), dtype=tf.float32, name=None),\n TensorSpec(shape=(None, 3), dtype=tf.float32, name=None),\n TensorSpec(shape=(), dtype=tf.float32, name=None))\n", | ||
| "output_type": "error", |
Collaborator
There was a problem hiding this comment.
You have errors in your notebook it appears.
Collaborator
|
@mehradans92 is this PR done yet? |
hgandhi2411
reviewed
Mar 10, 2021
Collaborator
|
@mehradans92 There are a few empty files in your changes. Were they committed by accident? |
Contributor
Author
|
@hgandhi2411 No, they are not empty. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.