Skip to content

add cacheTag suport#56

Open
gotson wants to merge 2 commits intouraimo:masterfrom
gotson:cachetag
Open

add cacheTag suport#56
gotson wants to merge 2 commits intouraimo:masterfrom
gotson:cachetag

Conversation

@gotson
Copy link
Copy Markdown

@gotson gotson commented Aug 23, 2021

should close #55

@gotson
Copy link
Copy Markdown
Author

gotson commented Aug 24, 2021

I was thinking we could also use the image tag (instead if latest) instead of changing the slug. Let me know which you prefer.

martin-g
martin-g approved these changes Oct 25, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@martin-g martin-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks like a more generic solution than #100.

Just one comment: instead of using 'default' as a default cache tag I suggest to use env.GITHUB_JOB

@uraimo uraimo mentioned this pull request Oct 25, 2022
Open
@felfert felfert mentioned this pull request May 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@martin-g martin-g martin-g approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cache conflict?

2 participants

@gotson @martin-g