Conversation
rlepinski
reviewed
Sep 4, 2026
|
|
||
| Task { | ||
| let updates = await Airship.featureFlagManager.featureFlagStatusUpdates.compactMap { | ||
| ($0 as? FeatureFlagUpdateStatus).map(FeatureFlagStatusProxy.init) |
Contributor
There was a problem hiding this comment.
what does compactMap return? I think you can just do a guard cast in the for await below
rlepinski
approved these changes
Sep 4, 2026
Ulrico972
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Adds feature flag update status, a status changed event, and waitRefresh to the iOS and Android proxies.
Why are these changes necessary?
Lets wrappers gate launch decisions on fresh flag data and react when rules update later, for MOBILE-5857.
How did you verify these changes?
Android compiled against a locally published SDK build with the new public waitRefresh, and iOS built as part of the RN example app.
Anything else a reviewer should know?
Android needs the next SDK release with public FeatureFlagManager.waitRefresh (urbanairship/android-library-dev#2161), so CI stays red until the 20.12.0 pin gets bumped.