Prioritize defaultText over value in docs #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test default ran into a different bug so im avoiding that
dearchap
reviewed
Apr 12, 2025
| @@ -565,21 +565,19 @@ func getFlagDefaultValue(f cli.DocGenerationFlag) string { | |||
| return "" | |||
| } | |||
|
|
|||
| if v, ok := f.(interface{ GetValue() string }); ok { | |||
There was a problem hiding this comment.
@joshuaswickirl i'm having a hard time wrapping my head around this. You say that DocGenerationFlag has removed GetValue ?? It's still there. So I'm confused why we need all this in the first place. Moreover there is no need to use reflection here. You should be able to use be existing functions to achieve the desired result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where the default value is dynamic or programmatic, it'd be nice to be able to align the docs with the help text.
https://cli.urfave.org/v3/examples/flags/advanced/#default-values-for-help-output