Skip to content

Comments

Settings#128

Merged
uroni merged 2 commits intouroni:devfrom
cptKNJO:settings
Jun 30, 2025
Merged

Settings#128
uroni merged 2 commits intouroni:devfrom
cptKNJO:settings

Conversation

@cptKNJO
Copy link
Contributor

@cptKNJO cptKNJO commented Jun 27, 2025

This PR adds the following features:

  • Design general layout of the settings page, including:
    • A select box for selecting the client to configure
    • A select box for selecting the group (if there are any)
    • A button to add a new group
  • Components for settings: for string, checkbox, number
  • Server settings
    • with hidden advanced settings

Screenshots

Settings layout

localhost_5173_(Small laptop) (1)

Hidden advanced settings
Screenshot from 2025-06-27 08-49-09
Screenshot from 2025-06-27 08-49-23

Resettable fields (autosaved if valid)
Screenshot from 2025-06-27 08-52-49

@uroni
Copy link
Owner

uroni commented Jun 30, 2025

Looks good!

Two things:

  • Saving the settings is pretty expensive with many clients since it involves updating a lot of in-memory structures and the clients loading the updated settings from the server. I guess we can just try if it has acceptable performance as is, but it might need to be changed otherwise. It is definitely perhaps a more user-friendly choice
  • The navigation side-bar might not be optimal. I'd prefer it to be a separate one, instead of replacing most top-level one. When listing the clients it does not look good when the client name is too long (currently this is selected via pop-up select box which increases size with client name length). The select box on the bottom seems to be constrained to the side-bar as well.

@uroni uroni merged commit 6949c6b into uroni:dev Jun 30, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants