Conversation
✅ Deploy Preview for ui-use-ink ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
peterwht
changed the title
peterwht
force-pushed
the
peter/update-polkadot-js
branch
3 times, most recently
from
28735e6 to
b8e5376
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the polkadot.js version. This solves a bug where uploading a contract wouldn't automatically recognize the deployed contract and would require going to polkadot.js/apps and viewing events, then adding by address.
An important thing to note about this PR, is that the @polkadot/type-augment is autogenerated, but results in mismatch types for contract instantiation and invoking.
Note the type here: https://github.com/polkadot-js/api/blob/v15.8.1/packages/types/src/interfaces/contracts/types.ts#L73. This is correct and matches the older version.
However, the type-augment now uses a different type (generated types) 4.2/packages/api-augment/src/substrate/runtime.ts#L169C1-L191C7. So, this PR had to do some converting to get to our desired types.