-
Notifications
You must be signed in to change notification settings - Fork 455
Support ABI cfg
flag in codegen
#2501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+1,009
−369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑These are the results when building the Show Results
Link to the run | Last update: Mon May 19 16:01:21 CEST 2025 |
0f573e2
to
07d18ca
Compare
cfg
flag cfg
flag in codegen
2113c73
to
298411c
Compare
This was referenced May 16, 2025
f0293af
to
2f6ad68
Compare
cc4317a
to
74004b7
Compare
74004b7
to
e2db1e2
Compare
d92719d
to
e2a1e93
Compare
e2a1e93
to
5d2257e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part 3/3 and closes #2479
cargo-contract
orpallet-revive
?Description
cfg
options for generating ABI specific code (e.g.#[cfg(ink_abi = "sol")]
)cargo contract test
subcommand that propagates the ABI specified inCargo.toml
into the build environment for testsink
crate ui tests to support passing the ABI viacfg
flagsSee #2479 for details about "crate-level ABI declaration"
Also related:
Cargo.toml
and propagate ABI into build environment viacfg
flag cargo-contract#2033cargo contract test
subcommand cargo-contract#2034Checklist before requesting a review
CHANGELOG.md