Playwright: Create a New Collection and Validate Rejection of Duplicate Collection Creation. #4691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-bruno
requested changes
May 29, 2025
| } | ||
|
|
||
| test('Create a New Collection and Verify the Duplicate Collection Creation Should Not be Allowed', async ({ page }) => { | ||
| const collection_location = '/Users/vedpr/Documents/bruno_tests'; |
There was a problem hiding this comment.
- Please make sure we use a dynamic path that will work on any system/environment
- Please use camelCase naming pattern for variables for consistency
| const { execSync } = require('child_process'); | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Please remove unnecessary line breaks. Keep just one line break here
| await page.getByLabel('Location').fill(await collection_location); | ||
| await page.getByRole('button', { name: 'Create', exact: true }).click(); | ||
|
|
||
| //await page.pause(); |
There was a problem hiding this comment.
Please remove unwanted commented codes
| await page.getByLabel('Name').press('Tab'); | ||
| await page.getByLabel('Location').fill(collection_location); | ||
| await page.getByRole('button', { name: 'Create', exact: true }).click(); | ||
| await expect(page.getByText('An error occurred while')).toBeVisible(); |
There was a problem hiding this comment.
Please add a line break between assertions and page interactions.
I think it makes more sense and readable if we can put the portion of error message which states duplicate collection or collection already exists
| const collection_location = '/Users/vedpr/Documents/bruno_tests'; | ||
| const collectionName = generateRandomCollectionName(); | ||
| // ------------code from playwright------------ // | ||
| await page.getByRole('img').first().click(); |
There was a problem hiding this comment.
We need to start adding reliable element hooks or use ids so the tests wont fail when new elements are added to the page
| const randomWord = () => Math.random().toString(36).substring(2, 6); | ||
| const adj = adjectives[Math.floor(Math.random() * adjectives.length)]; | ||
| const noun = nouns[Math.floor(Math.random() * nouns.length)]; | ||
| return `${adj}-${noun}-${randomWord()}`; |
There was a problem hiding this comment.
Please add a line break above return statement for better readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.
Jira: BRU-1037