Skip to content

fix(RequestTabPanel): update loading message for better user feedback#7492

Merged
bijin-bruno merged 1 commit intousebruno:mainfrom
chirag-bruno:fix/error-message-change
Mar 16, 2026
Merged

fix(RequestTabPanel): update loading message for better user feedback#7492
bijin-bruno merged 1 commit intousebruno:mainfrom
chirag-bruno:fix/error-message-change

Conversation

@chirag-bruno
Copy link
Collaborator

@chirag-bruno chirag-bruno commented Mar 15, 2026

Description

Contribution Checklist:

  • I've used AI significantly to create this pull request
  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

Summary by CodeRabbit

  • Bug Fixes
    • Improved messaging when request tabs are loading - users now see "Loading..." instead of "An error occurred!" while content is being prepared.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 15, 2026

Walkthrough

A single user-facing message in RequestTabPanel is updated from "An error occurred!" to "Loading..." when no active or focused tab exists. No control flow or error handling logic is modified.

Changes

Cohort / File(s) Summary
UI Message Update
packages/bruno-app/src/components/RequestTabPanel/index.js
Changed user-facing message from "An error occurred!" to "Loading..." for the no active/focused tab state.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • helloanoop
  • lohit-bruno
  • naman-bruno
  • bijin-bruno

Poem

Loading, loading, here we go,
No more errors bringing woe,
One line changed, the message bright,
From gloom to hope in a single sight! ⏳✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating a loading message in RequestTabPanel for improved user feedback, which matches the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@packages/bruno-app/src/components/RequestTabPanel/index.js`:
- Around line 179-180: The current check treats activeTabUid being null (a valid
"no active tab" state) as a loading state; update RequestTabPanel to
differentiate null vs undefined: use activeTabUid === null (or !activeTabUid but
explicitly check for null) to render a "no active tab" / empty state and only
render "Loading..." when focusedTab is undefined (or when a real loading flag is
set). Concretely, change the condition that returns "Loading..." to only trigger
when focusedTab === undefined (or a designated loading flag), and add a separate
branch for activeTabUid === null that returns an appropriate empty/no-tab UI;
refer to the RequestTabPanel component and the activeTabUid / focusedTab symbols
when making the change.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6d524af0-5b1a-44d4-bd99-86f8d7c7d43f

📥 Commits

Reviewing files that changed from the base of the PR and between 83ddfc3 and 8659aae.

📒 Files selected for processing (1)
  • packages/bruno-app/src/components/RequestTabPanel/index.js

Comment on lines 179 to +180
if (!activeTabUid || !focusedTab) {
return <div className="pb-4 px-4">An error occurred!</div>;
return <div className="pb-4 px-4">Loading...</div>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Loading state conflates with valid “no active tab” state.

activeTabUid can be null in normal flows (e.g., when tabs are closed in packages/bruno-app/src/providers/ReduxStore/slices/tabs.js), so showing "Loading..." here can become a permanent misleading state.

Suggested fix
-  if (!activeTabUid || !focusedTab) {
-    return <div className="pb-4 px-4">Loading...</div>;
-  }
+  if (!activeTabUid) {
+    return <div className="pb-4 px-4">No tab selected</div>;
+  }
+
+  if (!focusedTab) {
+    return <div className="pb-4 px-4">Loading...</div>;
+  }
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@packages/bruno-app/src/components/RequestTabPanel/index.js` around lines 179
- 180, The current check treats activeTabUid being null (a valid "no active tab"
state) as a loading state; update RequestTabPanel to differentiate null vs
undefined: use activeTabUid === null (or !activeTabUid but explicitly check for
null) to render a "no active tab" / empty state and only render "Loading..."
when focusedTab is undefined (or when a real loading flag is set). Concretely,
change the condition that returns "Loading..." to only trigger when focusedTab
=== undefined (or a designated loading flag), and add a separate branch for
activeTabUid === null that returns an appropriate empty/no-tab UI; refer to the
RequestTabPanel component and the activeTabUid / focusedTab symbols when making
the change.

@bijin-bruno bijin-bruno merged commit 7e71776 into usebruno:main Mar 16, 2026
9 checks passed
lohit-bruno pushed a commit to lohit-bruno/bruno that referenced this pull request Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants