chore: change app builder to bruno team#8218
Conversation
sid-bruno
requested review from
bijin-bruno,
helloanoop,
lohit-bruno and
naman-bruno
as code owners
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe PR switches macOS signing identity to Bruno Software, Inc. (P3WTZH48ZB) and updates the notarization script to pass ChangesmacOS Signing and Notarization Credential Update
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates the macOS signing and notarization configuration for the Bruno Electron app to use the Bruno team/certificate, aligning the build pipeline with the new Apple developer team settings.
Changes:
- Switch macOS code signing
identityin the Electron Builder config to the Bruno Software, Inc. certificate/team. - Update notarization configuration to use the new ASC provider/team id and explicitly select
notarytool. - Adjust notarization completion logging to reference the app path.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/bruno-electron/notarize.js | Updates notarization parameters (tool/provider/team) and adjusts completion log output. |
| packages/bruno-electron/electron-builder-config.js | Updates macOS signing identity to the Bruno Software, Inc. team certificate. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/bruno-electron/notarize.js`:
- Around line 23-30: The notarize options object passed in
packages/bruno-electron/notarize.js currently includes ascProvider which is
invalid for tool: 'notarytool'; remove the ascProvider: 'P3WTZH48ZB' entry from
the options (keep tool: 'notarytool', appBundleId/appPath,
appleId/appleIdPassword, and teamId: 'P3WTZH48ZB') so authorization uses teamId
only and ensure APPLE_ID / APPLE_ID_PASSWORD are credentials for that same team;
update the options object referenced where notarize(...) or notarizeApp is
invoked to reflect this change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ed8df750-e302-400e-9466-f1c1cdff58b9
📒 Files selected for processing (2)
packages/bruno-electron/electron-builder-config.jspackages/bruno-electron/notarize.js
| tool: 'notarytool', | ||
| appBundleId: appId, | ||
| appPath: appPath, | ||
| appleId: process.env.APPLE_ID, | ||
| appleIdPassword: process.env.APPLE_ID_PASSWORD, | ||
| ascProvider: 'W7LPPWA48L' | ||
| ascProvider: 'P3WTZH48ZB', | ||
| teamId: 'P3WTZH48ZB' | ||
| }); |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
Does electron-notarize version 1.2.2 support the tool, teamId, and ascProvider options with notarytool?
💡 Result:
No. In electron-notarize version 1.2.2, the notarytool mode does not support the ascProvider option; it uses teamId instead. Evidence: In the electron/notarize package docs and code for the notarytool approach, authentication is configured with appleId/appleIdPassword (or an API key strategy) and requires teamId; the README example for notarytool uses teamId [1][2]. The source code for the notarytool submission builds authorization arguments with --team-id (derived from teamId) [3]. A reported issue notes notarytool mode fails if ascProvider is used/not provided as expected, and indicates ascProvider is required only for the legacy mode [4]. The commit that removed now-unusable legacy options also reflects that for the notarytool method you should use teamId rather than ascProvider [5]. So: - tool: yes (set tool: 'notarytool') — supported per types/docs [5][1] - teamId: yes (required for notarytool) [1][3][2] - ascProvider: no (not supported for notarytool; pertains to legacy) [4][5]
Citations:
- 1: https://github.com/electron/notarize/blob/main/README.md
- 2: https://packages.electronjs.org/notarize/main/index.html
- 3: https://github.com/electron/notarize/blob/main/src/notarytool.ts
- 4: notarytool mode fails if ascProvider argument not present electron/notarize#106
- 5: electron/notarize@f48a181
Fix notarize options for tool: 'notarytool' (remove ascProvider)
electron-notarize v1.2.2’s notarytool flow uses teamId for authorization and does not support the legacy ascProvider option—so the ascProvider: 'P3WTZH48ZB' entry should be removed when tool: 'notarytool'. Keep tool: 'notarytool' and teamId: 'P3WTZH48ZB', and ensure APPLE_ID / APPLE_ID_PASSWORD belong to the same Apple team referenced by that teamId.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/bruno-electron/notarize.js` around lines 23 - 30, The notarize
options object passed in packages/bruno-electron/notarize.js currently includes
ascProvider which is invalid for tool: 'notarytool'; remove the ascProvider:
'P3WTZH48ZB' entry from the options (keep tool: 'notarytool',
appBundleId/appPath, appleId/appleIdPassword, and teamId: 'P3WTZH48ZB') so
authorization uses teamId only and ensure APPLE_ID / APPLE_ID_PASSWORD are
credentials for that same team; update the options object referenced where
notarize(...) or notarizeApp is invoked to reflect this change.
Description
JIRA
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.
Summary by CodeRabbit