Skip to content

POC: support dynamic ESM imports in node-vm scripts #8394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Cicolas wants to merge 8 commits into
base: main
Choose a base branch
from
+766 −59
Open

POC: support dynamic ESM imports in node-vm scripts #8394

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ec9ee26
feat(node-vm): support dynamic esm imports in scripts
Cicolas Jun 27, 2026
7cbe557
fix(app): allow dynamic imports in script editor linting
Cicolas Jun 27, 2026
a53814e
test(app): cover dynamic import lint edge cases
Cicolas Jun 27, 2026
06842b6
test(app): cover dynamic import lint comments edge cases
Cicolas Jun 27, 2026
d0330f6
refactor(bruno-js): share local module path resolver
Cicolas Jun 28, 2026
5f1b9ae
feat(bruno-js): add custom ESM imports to node VM
Cicolas Jun 28, 2026
82ef085
docs(bruno-js): document node VM ESM loader helpers
Cicolas Jun 28, 2026
f7a3f70
test(bruno-js): cover collection ESM dependency imports
Cicolas Jun 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/bruno-js/src/sandbox/node-vm/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,15 @@ async function runScriptInNodeVm({
const wrappedScript = wrapScriptInClosure(script, SANDBOX.NODEVM);
let compiledScript;
try {
compiledScript = new vm.Script(wrappedScript, {
const scriptOptions = {
filename: vmFilename
});
};

if (vm.constants?.USE_MAIN_CONTEXT_DEFAULT_LOADER) {
scriptOptions.importModuleDynamically = vm.constants.USE_MAIN_CONTEXT_DEFAULT_LOADER;
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
}

compiledScript = new vm.Script(wrappedScript, scriptOptions);
} catch (error) {
// V8 puts "filename:line" as the first line of syntax error stacks.
// Parse it so the error formatter can map to the correct source location.
Expand Down
24 changes: 23 additions & 1 deletion packages/bruno-js/src/sandbox/node-vm/index.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ const { describe, it, expect, beforeEach, afterEach } = require('@jest/globals')
const fs = require('fs');
const path = require('path');
const os = require('os');
const vm = require('node:vm');
const { runScriptInNodeVm } = require('./index');

describe('node-vm sandbox', () => {
Expand Down Expand Up @@ -777,7 +778,7 @@ describe('node-vm sandbox', () => {
expect(context.bru.setVar).toHaveBeenCalledWith('result', 'cjs-100');
});

it('should fail when loading .mjs files (ES modules)', async () => {
it('should fail when requiring .mjs files (ES modules)', async () => {
const nodeModulesDir = path.join(collectionPath, 'node_modules', 'mjs-ext-module');
fs.mkdirSync(nodeModulesDir, { recursive: true });
fs.writeFileSync(
Expand All @@ -800,6 +801,27 @@ describe('node-vm sandbox', () => {
).rejects.toThrow();
});

it('should dynamically import .mjs files from node-vm scripts', async () => {
fs.writeFileSync(
path.join(collectionPath, 'esm-helper.mjs'),
'export function makeGreeting(name) { return `hello ${name} from esm`; }'
);

const script = `
const helper = await import('./esm-helper.mjs');
bru.setVar('result', helper.makeGreeting('bruno'));
`;

const context = {
bru: { setVar: jest.fn() },
console: console
};

await runScriptInNodeVm({ script, context, collectionPath, scriptingConfig: {} });

expect(context.bru.setVar).toHaveBeenCalledWith('result', 'hello bruno from esm');
});

it('should load module with package.json main field', async () => {
const nodeModulesDir = path.join(collectionPath, 'node_modules', 'custom-main');
fs.mkdirSync(path.join(nodeModulesDir, 'lib'), { recursive: true });
Expand Down