Make redirections to .org match with or without trailing slash and make them case-insensitive#2108
Open
sj213 wants to merge 2 commits into
Open
Make redirections to .org match with or without trailing slash and make them case-insensitive#2108sj213 wants to merge 2 commits into
sj213 wants to merge 2 commits into
Conversation
also make these matches case-insensitive.
bgruening
approved these changes
Jun 1, 2026
bgruening
left a comment
Member
There was a problem hiding this comment.
@itisAliRH let me know when you are ready and we can merge that
Contributor
Author
|
On second thought: the REs used in these rules should probably all be terminated with Should I update this PR accordingly? |
Member
|
Yes, please do so. Thanks! |
Contributor
Author
|
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main problem with the current match expressions for redirecting to .org seems to be that they do not match if the first path component is not terminated by a slash. The regexp matching introduced by this PR should fix this behaviour. In addition, an extra match clause to catch "galaxyproject.eu/eu" has been added. All the newly introduced regexp matches are case insensitive, so "EU", "Belgium" etc are also included.
CAVEAT EMPTOR: These expressions have been constructed according to the nginx manual but are completely untested