Skip to content

Add ticketsystem playbook#2143

Open
mira-miracoli wants to merge 6 commits into
usegalaxy-eu:masterfrom
mira-miracoli:ticketsystem
Open

Add ticketsystem playbook#2143
mira-miracoli wants to merge 6 commits into
usegalaxy-eu:masterfrom
mira-miracoli:ticketsystem

Conversation

@mira-miracoli

Copy link
Copy Markdown
Contributor

deploys zammad ticketsystem using docker compose
and adds traefik and tailscale so we can access the ticketsystem using a tailscale domain and tailscale SSL certificates.
part of:

deploys zammad ticketsystem using docker compose
and adds traefik and tailscale so we can access the
ticketsystem using a tailscale domain and tailscale
SSL certificates.
Comment thread templates/ticketsystem/docker_compose.yml.j2
Comment thread templates/ticketsystem/docker_compose.yml.j2

@domgz domgz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not reviewed templates/ticket_system/docker_compose.yml.j2, but I have heard that this PR still needs an update, so I will just drop my unfinished review and re-review later.

Comment thread group_vars/ticket_system.yml Outdated
@@ -0,0 +1,9 @@
---
hostname: "ticketsystem.{{ tailscale_domain }}"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this compatible with #2173?

Comment thread ticket_system.yml Outdated
hosts: ticketsystem
vars_files:
- secret_group_vars/all.yml
- group_vars/ticket_system.yml

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am aware you prefer to specify which files to load because you find it easier to track it this way. To me it feels like "swimming against a current" (the Ansible design) for not much benefit in exchange. Therefore it comes with downsides (e.g. why did I add another playbook/play for "mygroup" and it's not behaving like other playbooks for "mygroup"?, repeat for every play/playbook, etc).

If you happen to have "room" (and will) for internalizing the part of the variable precedence rules "group vars rule files/directories named after a group are automatically loaded for that group" that's welcome. I won't nag you about this again for a couple of months.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this rule and I also try to use it, pinky promise 😌

Comment thread ticket_system.yml Outdated
Comment on lines +51 to +65
- name: Clone zammad-docker-compose repository
ansible.builtin.git:
repo: "https://github.com/zammad/zammad-docker-compose.git"
dest: "{{ zammad_compose_dir }}"
version: "{{ zammad_compose_version }}"
force: false

- name: Template Docker Compose file
ansible.builtin.template:
src: ticket_system/docker_compose.yml.j2
dest: "{{ zammad_compose_dir }}/docker-compose.yml"
owner: root
group: root
mode: '0644'
register: zammad_compose_templated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is something I don't quite get: We are providing the Docker Compose file ourselves via the "Template Docker Compose file" task, and I do not see anything else of value in the Zammad repo (the .env.dist file is all comments). Do we actually need then to clone their repository?

Comment thread group_vars/ticket_system.yml Outdated
---
hostname: "ticketsystem.{{ tailscale_domain }}"
zammad_compose_dir: /opt/zammad-docker-compose
zammad_compose_version: a1feeee

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants