Skip to content

add support to tags - #2230

Draft
gsaudade99 wants to merge 1 commit into
usegalaxy-eu:masterfrom
gsaudade99:htcondor_V2
Draft

add support to tags#2230
gsaudade99 wants to merge 1 commit into
usegalaxy-eu:masterfrom
gsaudade99:htcondor_V2

Conversation

@gsaudade99

@gsaudade99 gsaudade99 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

This pull request updates the Galaxy job configuration templates to provide more flexible and explicit handler and plugin assignment, especially for HTCondor support. The changes introduce new fields for handler definitions, improve handler assignment logic, and add support for specifying handlers per tool.

Handler and plugin assignment improvements:

  • Changed the handler assignment field from assign_with to assign in both job_conf.yml and job_conf.yml.j2 to match the sample conf file
  • Added support for per-handler definitions via a new handler_definitions section, allowing tags and plugins to be set for individual handlers, and introduced a default_process for fallback configuration.
  • Enhanced the Jinja2 template logic to dynamically assign tags and plugins to handlers based on these new definitions, including support for plugin exclusion.

HTCondor support:

  • Added the htcondor_apiv2 plugin and its handler tag to the configuration, and ensured it can be excluded from the default process if needed.

Per-tool handler assignment:

  • Enabled specifying a handler for individual tools in the job configuration template, allowing more granular control over job routing.

ref: #1926

@gsaudade99 gsaudade99 self-assigned this Jul 29, 2026
@gsaudade99

gsaudade99 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

After rendering the template it would result in this diff:

image
✗ diff --color  /tmp/job_conf_old.yml /tmp/galaxy-job_conf.test.yml 
13a14,15
>   htcondor_apiv2:
>     load: galaxy.jobs.runners.htcondor:HTCondorJobRunner
---
>   assign:
244a247,250
>       tags:
>         - htcondor-apiv2
>       plugins:
>         - htcondor_apiv2
245a252,277
>       plugins:
>         - condor
>         - local
>         - pulsar_embedded
>         - pulsar_eu_be01
>         - pulsar_eu_bsc01
>         - pulsar_eu_cyf01
>         - pulsar_eu_cz01
>         - pulsar_eu_egi01
>         - pulsar_eu_eosc01
>         - pulsar_eu_es01
>         - pulsar_eu_fi01
>         - pulsar_eu_fr01
>         - pulsar_eu_hcmr01
>         - pulsar_eu_it01
>         - pulsar_eu_it02
>         - pulsar_eu_it03
>         - pulsar_eu_nemo
>         - pulsar_eu_no01
>         - pulsar_eu_pt01
>         - pulsar_eu_sk01
>         - pulsar_eu_tubitak01
>         - pulsar_eu_uca01
>         - pulsar_eu_ufz_eve01
>         - pulsar_eu_uk01
>         - pulsar_mira_runner
246a279,304
>       plugins:
>         - condor
>         - local
>         - pulsar_embedded
>         - pulsar_eu_be01
>         - pulsar_eu_bsc01
>         - pulsar_eu_cyf01
>         - pulsar_eu_cz01
>         - pulsar_eu_egi01
>         - pulsar_eu_eosc01
>         - pulsar_eu_es01
>         - pulsar_eu_fi01
>         - pulsar_eu_fr01
>         - pulsar_eu_hcmr01
>         - pulsar_eu_it01
>         - pulsar_eu_it02
>         - pulsar_eu_it03
>         - pulsar_eu_nemo
>         - pulsar_eu_no01
>         - pulsar_eu_pt01
>         - pulsar_eu_sk01
>         - pulsar_eu_tubitak01
>         - pulsar_eu_uca01
>         - pulsar_eu_ufz_eve01
>         - pulsar_eu_uk01
>         - pulsar_mira_runner
247a306,331
>       plugins:
>         - condor
>         - local
>         - pulsar_embedded
>         - pulsar_eu_be01
>         - pulsar_eu_bsc01
>         - pulsar_eu_cyf01
>         - pulsar_eu_cz01
>         - pulsar_eu_egi01
>         - pulsar_eu_eosc01
>         - pulsar_eu_es01
>         - pulsar_eu_fi01
>         - pulsar_eu_fr01
>         - pulsar_eu_hcmr01
>         - pulsar_eu_it01
>         - pulsar_eu_it02
>         - pulsar_eu_it03
>         - pulsar_eu_nemo
>         - pulsar_eu_no01
>         - pulsar_eu_pt01
>         - pulsar_eu_sk01
>         - pulsar_eu_tubitak01
>         - pulsar_eu_uca01
>         - pulsar_eu_ufz_eve01
>         - pulsar_eu_uk01
>         - pulsar_mira_runner
248a333,358
>       plugins:
>         - condor
>         - local
>         - pulsar_embedded
>         - pulsar_eu_be01
>         - pulsar_eu_bsc01
>         - pulsar_eu_cyf01
>         - pulsar_eu_cz01
>         - pulsar_eu_egi01
>         - pulsar_eu_eosc01
>         - pulsar_eu_es01
>         - pulsar_eu_fi01
>         - pulsar_eu_fr01
>         - pulsar_eu_hcmr01
>         - pulsar_eu_it01
>         - pulsar_eu_it02
>         - pulsar_eu_it03
>         - pulsar_eu_nemo
>         - pulsar_eu_no01
>         - pulsar_eu_pt01
>         - pulsar_eu_sk01
>         - pulsar_eu_tubitak01
>         - pulsar_eu_uca01
>         - pulsar_eu_ufz_eve01
>         - pulsar_eu_uk01
>         - pulsar_mira_runner
249a360,385
>       plugins:
>         - condor
>         - local
>         - pulsar_embedded
>         - pulsar_eu_be01
>         - pulsar_eu_bsc01
>         - pulsar_eu_cyf01
>         - pulsar_eu_cz01
>         - pulsar_eu_egi01
>         - pulsar_eu_eosc01
>         - pulsar_eu_es01
>         - pulsar_eu_fi01
>         - pulsar_eu_fr01
>         - pulsar_eu_hcmr01
>         - pulsar_eu_it01
>         - pulsar_eu_it02
>         - pulsar_eu_it03
>         - pulsar_eu_nemo
>         - pulsar_eu_no01
>         - pulsar_eu_pt01
>         - pulsar_eu_sk01
>         - pulsar_eu_tubitak01
>         - pulsar_eu_uca01
>         - pulsar_eu_ufz_eve01
>         - pulsar_eu_uk01
>         - pulsar_mira_runner

@gsaudade99

gsaudade99 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

@domgz @mira-miracoli want to take a look at this before opening for review?
This would tag handler 0 with the new htcondor runner so we could eventually assign our users to run tests there

From the rendered file perspective it looks good. Probably there are ways to improve the templating logic.

Also feel free to commit here

@gsaudade99 gsaudade99 changed the title add htcondor v2 to hanlder 0 add support to tags Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant