Skip to content

Conversation

@shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Jul 1, 2024

The current K8UP_WEEKLY_RANDOM_FEATURE_FLAG variable impacts both prune and check, so this should be phased out in favour of the new ones that leverage the actual supported featureflag support

LAGOON_FEATURE_FLAG(_FORCE|_DEFAULT)_K8UP_WEEKLY_RANDOM_CHECK
LAGOON_FEATURE_FLAG(_FORCE|_DEFAULT)_K8UP_WEEKLY_RANDOM_PRUNE

Setting these as global scope vars with the value enabled turns on the @weekly-random schedule for either check or prune

@shreddedbacon shreddedbacon marked this pull request as ready for review July 1, 2024 08:25
@shreddedbacon shreddedbacon added this to the 2.20.0 milestone Jul 1, 2024
@shreddedbacon
Copy link
Member Author

since this is a relatively harmless change, i'm going to merge it.

most of the minor diffs are just formatting changes, the bulk of the changes just use an OR to check if one flag or the other are set and the functionality of the templating is mostly unchanged

@shreddedbacon shreddedbacon merged commit 02d1bba into main Jul 3, 2024
@shreddedbacon shreddedbacon deleted the backup-check-randomness branch July 3, 2024 09:13
shreddedbacon added a commit that referenced this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants