feat: align default values for autogen/custom routes insecure behavior #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
This might be a BC break we don't want to make? I discovered the discrepancy while updating the docs in uselagoon/lagoon#3969. |
Yeah, not sure. I guess maybe need to do some checks to see how many of our users are explicitly setting it to redirect because of this. If the majority are doing it, then maybe it isn't that big of a deal. Most users could be handling the redirect elsewhere too (CDN layer eg..)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value for
insecureis currently different for autogenerates routes and custom routes. This PR changes the default value of autogenerated routes to be the same as custom routes,Redirect.