chore: adds fix-key-perms to set sshkey perms correctly for local-dev #3758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've not encountered an issue with this, but then I don't use those keys outside of the tests. Happy to see it merge though as its a just a small addition. But maybe it could be worth adding some comments in the makefile to its purpose/usage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a make routine to set the correct 600 permission on the local-dev SSH private keys. Github stores files as 644 by default, so the private keys need to be chmodded to 600 before they can be used for SSH'ing.
Given how rarely this is needed, I've not added the routine to any others, and kept it standalone