fix: race condition when making multiple keycloak API calls#4105
Open
rocketeerbkw wants to merge 1 commit into
Open
fix: race condition when making multiple keycloak API calls#4105rocketeerbkw wants to merge 1 commit into
rocketeerbkw wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General Checklist
Database Migrations
n/a
Description
A shared keycloak client is used in the Lagoon API. A race condition exists where an API request can fail or return unexpected data if it is done in the middle of another API request getting an access token.
The fix is to use a new/separate keycloak client for access tokens.
The easiest way to reproduce is to run the query described in #3907, but disable the group member cache so it is 100% reproducible:
Closing issues
closes #3907