fix: multiple issues with local-api-data-watcher-pusher#4107
Open
rocketeerbkw wants to merge 1 commit into
Open
fix: multiple issues with local-api-data-watcher-pusher#4107rocketeerbkw wants to merge 1 commit into
rocketeerbkw wants to merge 1 commit into
Conversation
* `tini` not setup properly, throwing warnings * `mcli` using wrong command, silently failing to copy files * Dockerfile leaving runtime dirs on host, requiring `sudo` to cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General Checklist
Database Migrations
n/a
Description
Fixes a number of issues discovered in
local-api-data-watcher-pusher:There is no
configcommand formcli. Maybe it was removed in some version, but all themcli cpcalls have been failing silently for awhile. The files were being written to a folder calledlocal-minioinstead of the minio service. Fixed by using correctaliascommand.This is an annoyance for local development. Running
mcli alias setcreates a/home/.mclifolder with root permisisons. Since docker-compose mounts/hometo the host it requiressudoto clean up the folder on the host. Fix is to run and mount scripts out of/appinstead of/home.Just a warning, but easy to fix by running
tinias the entrypoint only, not in the command.There is still one error left, will address in #4108.
Closing issues
n/a