Skip to content

refactor: status condition validations #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2024
Merged

refactor: status condition validations #276

merged 1 commit into from
Dec 30, 2024

Conversation

@shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Dec 30, 2024

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

Refactor the status conditions to validate and adjust on errors as required, mostly to help with uselagoon/build-deploy-tool#390

@shreddedbacon shreddedbacon marked this pull request as ready for review December 30, 2024 00:31
tobybellwood
tobybellwood approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me, thanks!

@shreddedbacon shreddedbacon merged commit 45fff5a into main Dec 30, 2024
10 checks passed
@shreddedbacon shreddedbacon deleted the build-step-status branch December 30, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobybellwood tobybellwood tobybellwood approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shreddedbacon @tobybellwood