feat: Refactor italic node to support nested inline elements#20
Merged
boojack merged 3 commits intousememos:mainfrom Mar 28, 2025
Merged
feat: Refactor italic node to support nested inline elements#20boojack merged 3 commits intousememos:mainfrom
boojack merged 3 commits intousememos:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a significant improvement to the italic node structure by refactoring it to use a child-based content representation instead of a simple string. This change enables better support for nested inline elements within italic text.
Key changes:
ast.Italicstruct to useChildren []Nodeinstead ofContent stringBenefits:
The changes have been tested thoroughly with various markdown inputs, including:
Other Changes:
Note:
This change also required a corresponding update in the main repository [https://github.com/usememos/memos], where this package is being used. A PR has been created there as well to ensure compatibility with the new Italic node structure.