Skip to content

Sync Codex review workflow to latest - #330

Closed
ashvathsureshkumar wants to merge 4 commits into
mainfrom
ci/codex-review-sync
Closed

Sync Codex review workflow to latest#330
ashvathsureshkumar wants to merge 4 commits into
mainfrom
ci/codex-review-sync

Conversation

@ashvathsureshkumar

Copy link
Copy Markdown
Collaborator

Syncs codex-review.yml to the latest canonical version used across the org.

What's new vs the version currently on main:

  • Devin-style deep-crawl review prompt: crawls the full repo (call sites, callers, tests, types, docs), assesses repo-wide ripple effects, not just the diff.
  • authorize job gates reviews to same-repo (non-fork) PRs so secrets are never exposed to fork content.
  • Concurrency key mirrors the full trusted-commenter gate, so an untrusted @codex review comment can't cancel an in-flight review.
  • Comment cleanup scoped to this bot's own comments and skips threads with replies.
  • Inline review posts a top-level body; pull_request trigger restricted to main.

No behavior change for normal same-repo PRs beyond a deeper, higher-signal review.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex flagged 1 item(s) inline below.

@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codex review

No issues found.

…mmits); drop non-load-bearing prompt wording

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex flagged 1 item(s) inline below.

Comment thread .github/workflows/codex-review.yml Outdated
@HarshaNalluru
HarshaNalluru requested a review from Copilot July 1, 2026 00:26
HarshaNalluru
HarshaNalluru previously approved these changes Jul 1, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Syncs the repository’s codex-review.yml GitHub Actions workflow to the latest org-wide “Codex PR Review” workflow, strengthening safety around trusted triggering and improving review signal via a deeper repository-crawl prompt.

Changes:

  • Restricts pull_request trigger to PRs targeting main and updates concurrency grouping to avoid untrusted @codex review comments canceling trusted runs.
  • Adds/clarifies same-repo (non-fork) gating before performing the secret-backed checkout/review.
  • Improves comment management: only edits/deletes this workflow’s own bot-authored comments and avoids deleting inline threads that have replies; adds a top-level review body for inline reviews.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/codex-review.yml Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex flagged 1 item(s) inline below.

@HarshaNalluru

Copy link
Copy Markdown
Contributor

I made a PR to a better workflow so it doesn't run on forks, closing this in favor of that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants