Redis standalone #822
Redis standalone #822
Conversation
This reverts commit 822ebc2.
|
@VyacheslavVanin , hi! Could you please take a look at updates? Is that approach you've mentioned? There is a doubt regarding method implementation SetConnectionInfo. As I understood calling this method and changing the connection params causes updating the nodes set and topology. Do not know whether it is applicable for a single node configuration or not. With empty method SetConnectionInfo implementation is easier but nodes configuration is completely static and can't be changed in runtime. |
| std::tie(conn_to_create_.host, conn_to_create_.port) = new_conn.HostPort(); | ||
| conn_to_create_.connection_security = new_conn.GetConnectionSecurity(); | ||
| conn_to_create_.read_only = new_conn.IsReadOnly(); | ||
| // conn_to_create_.password = ??? |
There was a problem hiding this comment.
Can we change type of conn_to_create_ to ConnectionInfoInt and just copy new_conn there?
It seems like there will be less conversions.
We will update password later. Let it be as is
@ae-ignatiev, hi! This method is called when secdist updates. And secdist contains hosts, ports and password, so it is applicable. I think we can leave password unchanged in SetConnectionInfo. We will fix this later |
Added pytest redis_standalone to run single redis instance. Plugin uses the same approach and configs as in ya testsuite plugins to run redis and redis cluster: https://github.com/yandex/yandex-taxi-testsuite/tree/develop/testsuite/databases/redis Cherry-pick some of the changes from userver-framework/userver#822 and move them into testsuite Co-authored-by: Aleksey Ignatiev <[email protected]>
|
We encountered issues in our internal build infrastructure while merging this PR. Working towards fixing the issues. Will merge the PR soon after that. Many thanks for the PR! |
Redis standalone implementation.
sharding_strategyRedisStandaloneStandaloneImplof interfaceSentinelImplBase. Based on cluster topology implementation without nodes discovery and singleClusterShardshard instance only.redis_standaloneto run single redis instance. Plugin use the same approach and configs as in ya testsuite plugins to run redis and redis cluster: https://github.com/yandex/yandex-taxi-testsuite/tree/develop/testsuite/databases/redispubsubintegration_teststhat was not used. Use testcase there to run standalone version. Tests for cluster fail there, marked them as failing cases for now.Note: by creating a PR or an issue you automatically agree to the CLA. See CONTRIBUTING.md. Feel free to remove this note, the agreement holds.