feat kafka-config: Better errors for kafka outdated configurations #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue #856 |
fdr400
reviewed
Feb 17, 2025
| @@ -155,8 +155,19 @@ ProducerConfiguration Parse(const yaml_config::YamlConfig& config, formats::pars | |||
| producer.security = config.As<SecurityConfiguration>(); | |||
| producer.rd_kafka_options = config["rd_kafka_custom_options"].As<RdKafkaOptions>({}); | |||
| producer.delivery_timeout = config["delivery_timeout"].As<std::chrono::milliseconds>(producer.delivery_timeout); | |||
| producer.queue_buffering_max = | |||
| config["queue_buffering_max"].As<std::chrono::milliseconds>(producer.queue_buffering_max); | |||
| // Handle gradual transition of renaming, done in versions 2.3 -> 2.4 | |||
There was a problem hiding this comment.
I am not sure this makes a lot of sense, because currently we have version 2.7 and your changes would be committed only in 2.8(
There was a problem hiding this comment.
Sorry for that API break, but it can not be undone
There was a problem hiding this comment.
Only force config validation can protect against such API-break changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request adds some warnings for usage of old name in producer config. Also, it throws exception for invalid usage, related to configuration migration.