feat redis: add sentinel_password option #925
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apolukhin
requested changes
May 15, 2025
Member
apolukhin
left a comment
apolukhin
left a comment
There was a problem hiding this comment.
Many thanks, looks great!
A few comments follow:
|
|
||
| for (const auto& sentinel : sentinels) { | ||
| EXPECT_TRUE(sentinel->WaitForFirstPingReply(kSmallPeriod)); | ||
| } |
Member
There was a problem hiding this comment.
Please add a subscribe test too
mistergad
pushed a commit
to mistergad/userver
that referenced
this pull request
Oct 8, 2025
…or non-subscribe cases This PR adds support for password authentication when connecting to Redis Sentinel. Closes: userver-framework#924 Allows configuring Sentinel password via `sentinel_password` option in secdist config. Example: ```json { "redis_settings": { "taxi-tmp": { "password": "redispwd", "sentinel_password": "sentpwd", /* <---- `AUTH sentpwd` will be executed on connection to sentinel` */ "database_index": 5, "secure_connection": false, "shards": [ { "name": "mymaster" } ], "sentinels": [ { "host": "127.0.0.1", "port": 26379 } ] } } } ``` Tests: протестировано CI Pull Request resolved: userver-framework#925 commit_hash:84ec2914e9b505c1655600cf3ce6ccf2281ae75c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for password authentication when connecting to Redis Sentinel.
Closes #924.
Allows configuring Sentinel password via
sentinel_passwordoption in secdist config.Example:
{ "redis_settings": { "taxi-tmp": { "password": "redispwd", "sentinel_password": "sentpwd", /* <---- `AUTH sentpwd` will be executed on connection to sentinel` "database_index": 5, "secure_connection": false, "shards": [ { "name": "mymaster" } ], "sentinels": [ { "host": "127.0.0.1", "port": 26379 } ] } } }Note: by creating a PR or an issue you automatically agree to the CLA. See CONTRIBUTING.md. Feel free to remove this note, the agreement holds.