Skip to content

Fix double counting of email events #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix double counting of email events #170

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd3d793
fix: prevent double counting in dashboard metrics
KMKoushik Jun 5, 2025
99567d1
update
KMKoushik Jun 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions apps/web/src/server/service/ses-hook-parser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,13 @@ export async function parseSesHook(data: SesEvent) {
return false;
}

const existingEvent = await db.emailEvent.findFirst({
where: {
emailId: email.id,
status: mailStatus,
},
});

if (
email.latestStatus === mailStatus &&
mailStatus === EmailStatus.DELIVERY_DELAYED
Expand All @@ -67,6 +74,7 @@ export async function parseSesHook(data: SesEvent) {
(mailData as SesBounce).bounceType === "Permanent";

if (
!existingEvent &&
[
"DELIVERED",
"OPENED",
Expand Down Expand Up @@ -147,14 +155,7 @@ export async function parseSesHook(data: SesEvent) {
mailData: data,
});

const mailEvent = await db.emailEvent.findFirst({
where: {
emailId: email.id,
status: mailStatus,
},
});

if (!mailEvent) {
if (!existingEvent) {
await updateCampaignAnalytics(
email.campaignId,
mailStatus,
Expand Down