Skip to content

Conversation

@Saedbhati
Copy link

fixes #109

@Saedbhati
Copy link
Author

@0xallam is ready for review

@0xallam
Copy link
Member

0xallam commented Dec 13, 2025

Hi @Saedbhati,
Thanks for contributing to Strix :)

I reviewed your PR. Overall it looks good, but what’s implemented is materially different from the feature/issue description.

The current approach adds an MCP client so Strix can connect to external tools/MCP servers. While that can be useful in some contexts, I don’t think it’s necessary for us right now - most of the core tools we’d want (Python, terminal, web search/browser, etc.) are already built into Strix. Adding an MCP client at this stage may also increase surface area and potentially confuse the agent without a clear benefit.

What the issue/feature is actually asking for is the opposite: we need Strix to act as an MCP server. That would allow Strix to be used as a tool by other agents (e.g., Cursor, Codex, etc.) and make integration much simpler.

If you’re open to it, I’d recommend re-scoping the PR in that direction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] MCP Support

2 participants