Add support for Waveshare 4.26" 800x480 e-ink panel + DFRobot Firebeetle ESP32-E #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I made a fork of the firmware for my own purposes, to add support for the following combo:
Posted it on reddit and after contacting @ryanckulp via mail he asked me if I could make a PR with my changes - and here I am :)
One of the biggest changes is removing the static
bb_epaperlib and including a newer version from pio registry.I had to do it cause the support for this Waveshare panel has been added in
2.0.0.I tried to make the rest of changes non-destructive, as in, for example, I've added preprocessor conditionals.
There is probably a better and more generic way to handle these cases, but I am not very fluent in C++ so I'll appreciate any tips to get this to a level that is acceptable for you.