Open
Conversation
On color e-ink panels (Spectra 6), the forced full refresh (bWait=1) makes the loading logo display very slow. Pressing the wake button previously triggered two full refreshes back-to-back: first the loading logo, then the actual content from the API. Remove the display_show_image() call on button wake-up so the device goes directly to downloading and displaying the new image. Error handling paths already show appropriate messages, so no content is lost. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
display_show_image()call on button wake-up inbl.cpp, eliminating one full e-ink refreshbWait=1is forced for all refreshes, making the loading logo display very slow — pressing the wake button previously caused two slow full refreshes back-to-backDetails
The preference resets (
PREFERENCES_DEVICE_REGISTERED_KEY,PREFERENCES_FILENAME_KEY) andneed_to_refresh_displayflag are preserved, so the download logic works unchanged. If the download fails, existing error handling already shows the appropriate message (MSG_TOO_BIG,WIFI_FAILED,FRIENDLY_ID, etc.).Test plan
🤖 Generated with Claude Code