Merged
Conversation
Terminus 0.52.0 removed base64 payload support, so the add-on needs a way to hand Terminus a URL it can fetch. URI mode sends the add-on's screenshot endpoint URL and lets Terminus pull the image itself. Legacy base64 mode is preserved as an opt-in for Terminus ≤ 0.51.0 users. A delivery-mode selector in the BYOS schedule config defaults to `data` so existing schedules keep working unchanged until users opt in to URI mode. Includes supporting pieces for the feature: - `addon_base_url` + `ByosDeliveryMode` added to the BYOS config - `BYOS_DEFAULT_DELIVERY_MODE` constant shared by UI and extractor - Screenshot URL builder threads `url` query param in generic mode so Terminus fetches hit the screenshot handler, not the UI HTML - Device preset selection auto-fills crop dimensions from viewport - Webhook format tests restructured by mode (URI / data / explicit) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Terminus 0.52.0 removed base64 payload support, so the add-on needs a way to hand Terminus a URL it can fetch. URI mode sends the add-on's screenshot endpoint URL and lets Terminus pull the image itself.
Legacy base64 mode is preserved as an opt-in for Terminus ≤ 0.51.0 users. A delivery-mode selector in the BYOS schedule config defaults to
dataso existing schedules keep working unchanged until users opt in to URI mode.Includes supporting pieces for the feature:
addon_base_url+ByosDeliveryModeadded to the BYOS configBYOS_DEFAULT_DELIVERY_MODEconstant shared by UI and extractorurlquery param in generic mode so Terminus fetches hit the screenshot handler, not the UI HTML