Fixed color palette dithering to preserve PLTE chunk#7
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
ikraamg
force-pushed
the
fix-colour-pallete-dithering
branch
from
6948fb0 to
8dd39d0
Compare
This comment has been minimized.
This comment has been minimized.
ikraamg
force-pushed
the
fix-colour-pallete-dithering
branch
3 times, most recently
from
166b622 to
32a88ee
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Refactored palette creation to use ImageMagick's mpr: (memory program register) instead of temp files, eliminating file I/O and cleanup issues. Key fixes: - Skip png:exclude-chunks for color palettes (was removing PLTE chunk) - Apply saturation boost BEFORE normalize (order matters) - Skip strip() for color palettes (was corrupting colormap) - Enable normalize + saturationBoost by default for color palettes Also extracted streamToBuffer() and configureOutputFormat() utilities to reduce duplication across processing functions.
ikraamg
force-pushed
the
fix-colour-pallete-dithering
branch
from
32a88ee to
ff5f7a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored palette creation to use ImageMagick's mpr: (memory program register) instead of temp files, eliminating file I/O and cleanup issues.
Key fixes:
Also extracted streamToBuffer() and configureOutputFormat() utilities to reduce duplication across processing functions.