Skip to content

Fiet 370 #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
victorshevtsov merged 3 commits into from
Jan 29, 2026
Merged

Fiet 370 #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc43e38
Update to fetch fees instead of account ID
xlassix Jan 22, 2026
6a8f92d
Fix spacing issue in broker.market call
xlassix Jan 22, 2026
47b8730
Revert removed FetchAccountId action
victorshevtsov Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/client.dev.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ function onClientReady() {
client.executeAction(
{
cex: "mexc",
action: Action.FetchAccountId,
action: Action.FetchFees,
},
Comment on lines 72 to 76

@coderabbitai coderabbitai Bot Jan 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Add symbol to FetchFees request to avoid guaranteed INVALID_ARGUMENT.

Server-side FetchFees now requires symbol, so this call will fail without it.

🛠️ Proposed fix 
 	client.executeAction(
 		{
 			cex: "mexc",
+			symbol: "ETHUSDT",
 			action: Action.FetchFees,
 		},
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
client.executeAction(
{
cex: "mexc",
action: Action.FetchAccountId,
action: Action.FetchFees,
},
client.executeAction(
{
cex: "mexc",
symbol: "ETHUSDT",
action: Action.FetchFees,
},
🤖 Prompt for AI Agents 
In `@src/client.dev.ts` around lines 72 - 76, The call to client.executeAction
with Action.FetchFees is missing the required symbol field causing an
INVALID_ARGUMENT error; update the request object passed to client.executeAction
(the call site using Action.FetchFees) to include a symbol property (e.g.,
symbol: "<MARKET_SYMBOL>" or the appropriate variable) alongside cex and action
so the server receives the required symbol parameter.

@victorshevtsov victorshevtsov Jan 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you replace FetchAccountId? After applying theses changes fiet-prover is unable to get account Id from neither sandbox nor real binance endpoint.

@coderabbitai coderabbitai Bot Jan 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check the Action enum definition to see if FetchAccountId still exists
echo "=== Action enum definition ==="
rg -n "enum Action" -A 20 src/proto/

echo -e "\n=== All references to FetchAccountId ==="
rg -n "FetchAccountId" 

echo -e "\n=== All references to FetchFees ==="
rg -n "FetchFees"

echo -e "\n=== Check if fiet-prover is mentioned in the codebase ==="
rg -n "fiet-prover"

Length of output: 959

🏁 Script executed:

#!/bin/bash
# Check the server.ts switch statement for Action handling
echo "=== Server.ts Action.FetchFees case ==="
rg -n "case Action.FetchFees" -B 2 -A 25 src/server.ts

echo -e "\n=== Check all case statements in the switch ==="
rg -n "case Action\." src/server.ts

echo -e "\n=== Check default case in switch ==="
rg -n "default:" -A 5 src/server.ts

Length of output: 1990

@victorshevtsov You're absolutely right to raise this concern. This is a breaking change that removes existing functionality.

The Problem

Looking at the code:

  1. Action.FetchAccountId still exists in the enum (line 58 of src/proto/node.proto)
  2. Action.FetchFees was added as a new action (line 59)
  3. However, in src/server.ts, the case handler for FetchAccountId was replaced with FetchFees

This means any requests with Action.FetchAccountId (from fiet-prover or other consumers) will now hit the default case and fail with INVALID_ARGUMENT: "Invalid Action".

The Fix

Both actions should coexist. The case Action.FetchAccountId: handler needs to be restored in src/server.ts alongside the new case Action.FetchFees: handler. Each should serve its distinct purpose:

  • FetchAccountId → returns account identifier
  • FetchFees → returns fee metadata and market info

Could you check what the original FetchAccountId implementation returned? It needs to be added back to the switch statement to restore backward compatibility with fiet-prover and other consumers.

✏️ Learnings added 
Learnt from: victorshevtsov
Repo: usherlabs/cex-broker PR: 23
File: src/client.dev.ts:72-76
Timestamp: 2026-01-29T17:09:48.143Z
Learning: In the cex-broker codebase, Action.FetchAccountId must remain implemented in src/server.ts to support external consumers like fiet-prover that depend on fetching account IDs from CEX endpoints; removing or replacing this handler breaks backward compatibility.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

metadata,
(err, result) => {
Expand Down
1 change: 1 addition & 0 deletions src/proto/node.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,4 +56,5 @@ enum Action {
FetchCurrency=9;
Call=10;
FetchAccountId=11;
FetchFees= 12;
}
40 changes: 40 additions & 0 deletions src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,7 @@ export function getServer(
}
break;
}

case Action.FetchAccountId: {
try {
let accountId = await broker.fetchAccountId();
Expand All @@ -234,6 +235,45 @@ export function getServer(
break;
}

case Action.FetchFees: {
if (!symbol) {
return callback(
{
code: grpc.status.INVALID_ARGUMENT,
message: `ValidationError: Symbol required`,
},
null,
);
}
try {
await broker.loadMarkets();
const market = await broker.market(symbol);

// Address CodeRabbit's concern: explicit handling for missing fees
const generalFee = broker.fees ?? null;
const feeStatus = broker.fees ? "available" : "unknown";

if (!broker.fees) {
log.warn(`Fee metadata unavailable for ${cex}`, { symbol });
}

return callback(null, {
proof: verityProof,
result: JSON.stringify({ generalFee, feeStatus, market }),
});
} catch (error) {
log.error(`Error fetching fees for ${symbol} from ${cex}:`, error);
callback(
{
code: grpc.status.INTERNAL,
message: `Error fetching fees from ${cex}`,
},
null,
);
}
break;
}

case Action.Call: {
const callSchema = Joi.object({
functionName: Joi.string()
Expand Down