Skip to content

pass symbol param#32

Merged
rsoury merged 1 commit intomasterfrom
fix-order
Feb 27, 2026
Merged

pass symbol param#32
rsoury merged 1 commit intomasterfrom
fix-order

Conversation

@outerlook
Copy link
Copy Markdown
Member

@outerlook outerlook commented Feb 27, 2026

…ponse field names to match ccxt conventions

Summary by CodeRabbit

  • Bug Fixes
    • Improved order details retrieval and cancellation by ensuring symbol information is properly passed to broker communications, enabling more reliable exchange-specific order operations.

@outerlook outerlook self-assigned this Feb 27, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 27, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 9ada911 and 397591b.

📒 Files selected for processing (1)
  • src/server.ts

Walkthrough

The pull request updates broker method calls in src/server.ts to pass the actual symbol parameter instead of undefined when fetching and canceling orders, enabling symbol-specific order resolution across exchanges. Package dependencies have also been adjusted.

Changes

Cohort / File(s) Summary
Broker Method Calls
src/server.ts
Updated fetchOrder and cancelOrder calls in GetOrderDetails and CancelOrder branches to pass symbol as the second argument instead of undefined.
Dependency Updates
package.json
Minor version or dependency adjustments (6 additions, 5 deletions).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A symbol once lost in the undefined void,
Now passed with purpose, no more to avoid!
Orders fetch cleanly, exchanges rejoice,
The broker now hears the exchange's true voice. 🎉

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-order

Comment @coderabbitai help to get the list of available commands and usage tips.

@rsoury rsoury merged commit c27f6b0 into master Feb 27, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants