Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion develop-requirements.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
pytest==6.2.5
wheel==0.38.1
mypy==0.930
pylint==2.12.2
pylint==4.0.4
twine==3.7.1
autoflake==1.4
autopep8==1.6.0
Expand Down
6 changes: 4 additions & 2 deletions nmcli/_connection.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def up(self, name: str, wait: int = None) -> None:
def down(self, name: str, wait: int = None) -> None:
raise NotImplementedError

def show(self, name: str, show_secrets: bool = False) -> ConnectionDetails:
def show(self, name: str, show_secrets: bool = False, active: bool = False) -> ConnectionDetails:
raise NotImplementedError

def reload(self) -> None:
Expand Down Expand Up @@ -88,10 +88,12 @@ def down(self, name: str, wait: int = None) -> None:
wait) + ['connection', 'down', name]
self._syscmd.nmcli(cmd)

def show(self, name: str, show_secrets: bool = False) -> ConnectionDetails:
def show(self, name: str, show_secrets: bool = False, active: bool = False) -> ConnectionDetails:
cmd = ['connection', 'show', name]
if show_secrets:
cmd += ["--show-secrets"]
if active:
cmd += ["--active"]
r = self._syscmd.nmcli(cmd)
results = {}
for row in r.split('\n'):
Expand Down
4 changes: 4 additions & 0 deletions tests/test_connection.py
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,10 @@ def test_show():
assert s.passed_parameters == [
'connection', 'show', name, "--show-secrets"]

connection.show(name, active=True)
assert s.passed_parameters == [
'connection', 'show', name, "--active"]


def test_reload():
s = DummySystemCommand()
Expand Down
Loading