Iterative term printer #421
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a let term `(let ((l1 phi1) ... (ln phin)) psi[l1/phi1 ... ln/phin])` it must not be the case that `li` appears in `psi[l1/phi1 ... ln/phin]` as a free variable. This commit guarantees this by introducing a let prefix in `Logic` and modifying it whenever a new variable is introduced such that its name is a proper prefix of the current let prefix. The current let prefix is modified by postfixing it with a character different from the first character after the proper prefix in the new variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current method of printing interpolants and models in
Interpretrelies onLogic::pp, which is a recursive implementation. This PR presents a more robust implementation calledTermPrinter, which is iterative and therefore requires a fixed-size stack. The printer still blows up thePTRefdag to a tree, similar toLogic::pp.The implementation is based on the
Rewriterclass. However, since the does not actually rewrite anything, I created aVisitorclass which allows passingLogic const &.Between
VisitorandRewritercodes there's some code duplication that maybe could be removed, but I'm not sure how right now.I didn't remove
Logic::ppbecause I think it still has its place, at least when running stuff from debugger, but maybe also (as it currently is done) for some error messages.