Skip to content

Comments

build: Release artifacts#6

Merged
usmansaleem merged 2 commits intomainfrom
fix_release_workflow_2
Mar 7, 2025
Merged

build: Release artifacts#6
usmansaleem merged 2 commits intomainfrom
fix_release_workflow_2

Conversation

@usmansaleem
Copy link
Owner

No description provided.

@usmansaleem usmansaleem requested a review from Copilot March 7, 2025 05:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR updates the CI workflow release artifacts to use the Git tag name (github.ref_name) instead of the project version output.

  • Update artifact naming convention in the CI workflow
  • Replace version variable with git reference name for release artifacts

Reviewed Changes

File Description
.github/workflows/ci.yaml Updated artifact file names to use github.ref_name instead of project_version.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

.github/workflows/ci.yaml:89

  • Changing from steps.project_version.outputs.project_version to github.ref_name may lead to unexpected artifact naming if the tag includes prefixes (e.g., 'v'). Consider ensuring that github.ref_name is formatted to match expected artifact versioning.
converter/build/distributions/converter-${{ github.ref_name }}.tar.gz

@usmansaleem usmansaleem requested a review from Copilot March 7, 2025 05:07
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR introduces changes to the CI configuration to support releasing artifacts with a designated publish version.

  • Added a job-level output (publish_version) based on the project version step.
  • Updated artifact file references to use the published version from the job outputs.

Reviewed Changes

File Description
.github/workflows/ci.yaml Adds job-level output and updates artifact references to use the new output

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

.github/workflows/ci.yaml:91

  • Using 'needs.build.outputs.publish_version' within the same 'build' job may not work as intended because job outputs should be referenced by downstream jobs via 'needs'. If the artifact upload step belongs to a different job, update the job dependency accordingly; otherwise, use the step outputs directly.
converter/build/distributions/converter-${{ needs.build.outputs.publish_version }}.tar.gz

@usmansaleem usmansaleem merged commit f38b9cb into main Mar 7, 2025
2 checks passed
@usmansaleem usmansaleem deleted the fix_release_workflow_2 branch March 7, 2025 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant