Conversation
There was a problem hiding this comment.
PR Overview
This PR updates the CI workflow release artifacts to use the Git tag name (github.ref_name) instead of the project version output.
- Update artifact naming convention in the CI workflow
- Replace version variable with git reference name for release artifacts
Reviewed Changes
| File | Description |
|---|---|
| .github/workflows/ci.yaml | Updated artifact file names to use github.ref_name instead of project_version. |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
.github/workflows/ci.yaml:89
- Changing from steps.project_version.outputs.project_version to github.ref_name may lead to unexpected artifact naming if the tag includes prefixes (e.g., 'v'). Consider ensuring that github.ref_name is formatted to match expected artifact versioning.
converter/build/distributions/converter-${{ github.ref_name }}.tar.gz
There was a problem hiding this comment.
PR Overview
This PR introduces changes to the CI configuration to support releasing artifacts with a designated publish version.
- Added a job-level output (publish_version) based on the project version step.
- Updated artifact file references to use the published version from the job outputs.
Reviewed Changes
| File | Description |
|---|---|
| .github/workflows/ci.yaml | Adds job-level output and updates artifact references to use the new output |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
.github/workflows/ci.yaml:91
- Using 'needs.build.outputs.publish_version' within the same 'build' job may not work as intended because job outputs should be referenced by downstream jobs via 'needs'. If the artifact upload step belongs to a different job, update the job dependency accordingly; otherwise, use the step outputs directly.
converter/build/distributions/converter-${{ needs.build.outputs.publish_version }}.tar.gz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.