Merged
Conversation
Collaborator
|
https://github.com/usnistgov/ACVP/blob/master/index.html and https://github.com/usnistgov/ACVP/blob/master/README.md need to be updated to list the new HMAC 2.0 algo tests. |
Collaborator
Author
|
Thanks. Also reminder to self to update |
livebe01
reviewed
Jun 6, 2025
| | tcId | Numeric identifier for the test case, unique across the entire vector set | integer | ||
| | key | The value of the key | hex | ||
| | msg | Value of the message | hex | ||
| | macLen | Length of MAC in bits to generate | integer |
Collaborator
There was a problem hiding this comment.
add rows for keyLen and msgLen here
livebe01
reviewed
Jun 6, 2025
| "tcId": 1, | ||
| "key": "0CBB3AA866", | ||
| "msg": "28CD4091D45F28CD", | ||
| "macLen": 128 |
Collaborator
There was a problem hiding this comment.
add keyLen and msgLen values at the test case level in the example test cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies the test groups for HMAC by pulling the
macLenandkeyLenproperties into the test cases. Also adds themessageLenregistration property.