Skip to content

Reimplement NFIQ2::Data with std::vector storage#403

Closed
gfiumara wants to merge 2 commits intomasterfrom
nfiq2-data
Closed

Reimplement NFIQ2::Data with std::vector storage#403
gfiumara wants to merge 2 commits intomasterfrom
nfiq2-data

Conversation

@gfiumara
Copy link
Copy Markdown
Member

We should not subclass STL types, and libc++ is removing the base template for std::char_traits which breaks the previous code

Closes #401.

We should not subclass STL types, and libc++ is removing the base
template for std::char_traits which breaks the previous code
@gfiumara gfiumara added library Development interface and library clean-up General code enhancement labels May 21, 2025
@github-actions
Copy link
Copy Markdown

❌ Conformance regression test for macOS-15 (arm64) failed. Please review the artifacts for this run.

@github-actions
Copy link
Copy Markdown

❌ Conformance regression test for ubuntu-22.04 (x64) failed. Please review the artifacts for this run.

@github-actions
Copy link
Copy Markdown

❌ Conformance regression test for macOS-14 (arm64) failed. Please review the artifacts for this run.

@github-actions
Copy link
Copy Markdown

❌ Conformance regression test for ubuntu-24.04 (x64) failed. Please review the artifacts for this run.

@github-actions
Copy link
Copy Markdown

❌ Conformance regression test for macOS-13 (x64) failed. Please review the artifacts for this run.

@github-actions
Copy link
Copy Markdown

❌ Conformance regression test for windows-2019 (x64) failed. Please review the artifacts for this run.

@github-actions
Copy link
Copy Markdown

❌ Conformance regression test for windows-2022 (x86) failed. Please review the artifacts for this run.

@github-actions
Copy link
Copy Markdown

❌ Conformance regression test for windows-2025 (x64) failed. Please review the artifacts for this run.

@github-actions
Copy link
Copy Markdown

❌ Conformance regression test for windows-2019 (x86) failed. Please review the artifacts for this run.

@github-actions
Copy link
Copy Markdown

❌ Conformance regression test for windows-2022 (x64) failed. Please review the artifacts for this run.

@github-actions
Copy link
Copy Markdown

❌ Conformance regression test for ubuntu-24.04 (x64) failed. Please review the artifacts for this run.

@github-actions
Copy link
Copy Markdown

❌ Conformance regression test for ubuntu-22.04 (x64) failed. Please review the artifacts for this run.

@gfiumara
Copy link
Copy Markdown
Member Author

Closing PR due to malfunctioning github-actions. Will reopen now that action is (hopefully) fixed.

@gfiumara gfiumara closed this May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clean-up General code enhancement library Development interface and library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Transition non-standard use of basic_string in Data

1 participant