Reimplement NFIQ2::Data with std::vector storage#404
Open
Reimplement NFIQ2::Data with std::vector storage#404
Conversation
We should not subclass STL types, and libc++ is removing the base template for std::char_traits which breaks the previous code
|
✅ All conformance tests passed Conformance Test Results
Summary: 10 passed, 0 failed (10 total) About this testThis workflow runs conformance regression tests across multiple operating systems and architectures to ensure consistent behavior of the NFIQ2 library. |
|
❌ Conformance tests failed Conformance Test ResultsNo test result files found! About this testThis workflow runs conformance regression tests across multiple operating systems and architectures to ensure consistent behavior of the NFIQ2 library. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should not subclass STL types, and libc++ is removing the base template for
std::char_traitswhich breaks the previous codeCloses #401.