-
Notifications
You must be signed in to change notification settings - Fork 205
Update component and inventory prop type names #2111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Update component and inventory prop type names #2111
Conversation
@iMichaela will you have a chance to review this PR? We are planning a tentative release in the middle of March. These issues with the constraints in the core models are harder to work around than others for which I just added updates. If these cannot be reviewed, merged, and published into a release model, we can only workaround some of the issues. If not, that is fine, but FedRAMP leadership will have to consider alternatives to NIST-maintained models for that release. Thanks in advance for your help and cooperation. |
Hello, @iMichaela, these proposed changes are to meaningfully align conflicting requirements in the internal models and FedRAMP use of core values. We will need to have duplicate and confusing use of certain If not, we will have to consider alternative solutions, potentially forks of the models. Let us know. |
@iMichaela any update on these changes, particularly #2111 (comment)? At this juncture, we may have to consider the publication of alternate models in a fork to finalize an upcoming release otherwise. |
Welcome back. I can prioritize this PR. Coming back to the |
Hi, @iMichaela, I've been here the whole time. 😄
I did not have a good idea for an alternate changed name for the |
@iMichaela I proposed a new ID because I have not heard back with a proposal, so I just made one in #2111 (comment). Can you let us know because I will have to potentially push back a release schedule or consider forking or disabling internal constraints and ignore a good portion of the core models to not have conflicting data quality checks between core OSCAL and FedRAMP requirements that should have been aligned prior. Let me know if you need further details to advance a review. |
@aj-stein-gsa - I have something to finish now and will work on PRs later today and continue tomorrow afternoon. What is your schedule? Let's try to work toward your schedule. |
@iMichaela I was hoping we could opt for a minor 1.1.4 release in anticipation of a subsequent FedRAMP release some time tomorrow for such a change. Is that feasible? This is why I opened the PR last month. |
@aj-stein-gsa -- Let's do it because I want to fix the bug I found while working on #2107. I know it is super important for FedRAMP. |
I appreciate it. Barring alternative feedback, I committed the constraint ID with my proposal because you and no one else provided one. Let me know what else I can do. |
Specific request is in the comment thread below. usnistgov#2111 (comment)
Committer Notes
Closes #2086 and #2092.
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)
Changes to Core Features:
Have you included examples of how to use your new feature(s)?Have you updated the OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the OSCAL-Pages and OSCAL_Reference repositories.