Fix warnings and set them to be errors #242
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garlic-hub
commented
Jun 19, 2025
|
|
||
| returnIndex = ((size_t) floor((1.0 - alpha) * ((double) simulation_rounds))) - 1; | ||
| assert((returnIndex >= 0) && (returnIndex < simulation_rounds)); | ||
| assert(returnIndex < simulation_rounds); |
Author
There was a problem hiding this comment.
Bonus of fixing the signed unsigned comparison on this line is that >= 0 is not required anymore since unsigned values can't be negative
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Wall and Wextra warnings emitted from gcc 13.3. Also enables Werror to prevent new warnings in the future. Attempted to test with clang as well, but my distro doesn't seem to build it with OMP support enabled.