Skip to content

Conversation

@colton-lapp
Copy link
Collaborator

@colton-lapp colton-lapp commented Nov 12, 2025

This PR makes two small UI tweaks.

Fix display for artifact tasks to remove unused "Input Parameters":

  • Remove the "Input Parameters" from the Artifact Plugin Task registration table (you cannot set input parameters for Artifact Plugin Tasks in the UI) while keeping "Input parameters" for Function Plugin Tasks

Enhance UI by adding loading indicators:

  • Implement loading animation with minimum 300ms loading for all tables i.e. entrypoints, jobs, artifacts, etc (implemented minimum loading time to remove "flicker" effect. We could implement advanced logic to not show the loading animation for the first 300ms or so instead.

Potential future changes we could work on after discussing with the team:

  • Enable multiple selection and deletion in all tables. Checkboxes on each row would allow you to select multiple, and then a button would let you delete all of them.
  • "Save parameter and add another" feature - when creating an entrypoint parameter, add a button that says "Save parameter and add another" which would save the current parameter but keep the dialogue box open for additional parameters. Small quality of life improvement to increase speed
  • Job log display tweaks - adding color for severity, syntax highlighting potentially, filters, etc to log view for job

@colton-lapp colton-lapp changed the title Make small UI Tweaks feat(UI): make small UI Tweaks Nov 13, 2025
size="md" flat dense round
@click.stop="props.expand = !props.expand"
:icon="props.expand ? 'expand_less' : 'expand_more'"
Thinker: :icon="props.expand ? 'expand_less' : 'expand_more'"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what "Thinker" is here?

title="Plugins"
v-model:selected="selected"
@edit="router.push(`/plugins/${selected[0].id}`)"
selection="multiple" @edit="router.push(`/plugins/${selected[0].id}`)"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put on separate lines

>
<template v-slot:header="props">
<q-tr :props="props">
<q-th auto-width v-if="selection === 'multiple'">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nitpick, but some of the indents on the edits in this file are off

@henrychoy
Copy link
Collaborator

Hi Colton,
I think the changes look great. The 300ms minimum loading time for the table looks good.

The multiselect/delete on the plugins page looks good as well, but it clashes with the "click to open" workflow that the rest of the pages follow. think if the team really wants the ability to multiselect, maybe we can add a small "delete multiple" checkbox somewhere in the header of the table. But I think the rest of the team will have some thoughts as to how we want to approach multi-select in general, will probably be a good topic for next call.

@colton-lapp
Copy link
Collaborator Author

Hi Colton, I think the changes look great. The 300ms minimum loading time for the table looks good.

The multiselect/delete on the plugins page looks good as well, but it clashes with the "click to open" workflow that the rest of the pages follow. think if the team really wants the ability to multiselect, maybe we can add a small "delete multiple" checkbox somewhere in the header of the table. But I think the rest of the team will have some thoughts as to how we want to approach multi-select in general, will probably be a good topic for next call.

I agree the team should probably weigh in on the multi-select / delete logic. I could clean up the PR to address your edits and delete the text artifact for loading though. I wonder if there is some way to put the "wait 300 ms" logic into a decorator or standalone wrapper function so that it's not repeated everywhere... maybe eventually we could enhance the logic to not show loading if the request takes less than 100ms. I'm still very new to Vue / Quasar, so I don't really know what the best pattern is here.

@henrychoy
Copy link
Collaborator

Hi Colton, I think the changes look great. The 300ms minimum loading time for the table looks good.
The multiselect/delete on the plugins page looks good as well, but it clashes with the "click to open" workflow that the rest of the pages follow. think if the team really wants the ability to multiselect, maybe we can add a small "delete multiple" checkbox somewhere in the header of the table. But I think the rest of the team will have some thoughts as to how we want to approach multi-select in general, will probably be a good topic for next call.

I agree the team should probably weigh in on the multi-select / delete logic. I could clean up the PR to address your edits and delete the text artifact for loading though. I wonder if there is some way to put the "wait 300 ms" logic into a decorator or standalone wrapper function so that it's not repeated everywhere... maybe eventually we could enhance the logic to not show loading if the request takes less than 100ms. I'm still very new to Vue / Quasar, so I don't really know what the best pattern is here.

I think the way you implemented the minimum 300ms loading is the most logical, even if there's some repeated code. One other idea is to implement the minimum loading time in the getData function in the dataApi.ts file... but looks like not all tables use that function (for example the job logs table), and some dropdowns use that function as well. Doing it in TableComponent was my next idea, but I dont see an easy way to implement it there. If we try to respect the separation of concerns, I think the way you did it is probably the best way.

@colton-lapp
Copy link
Collaborator Author

Sounds good! Well I deleted/reverted the code that implemented the "delete multiple" in the PluginsView, which should address all your comments. If it looks good to you, we can merge the loading functionality and the artifact task registration changes into dev

@colton-lapp colton-lapp marked this pull request as ready for review November 21, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants