Made only one call to search field list.#333
Open
chuanlin2018 wants to merge 2 commits into
Open
Conversation
Contributor
|
I modified the angular.json to fix the icons issue. Works! Thanks Chuan. |
shiftmed
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of calling searchFieldsListService.getSearchFields() from search-panel, filters and result component, now only app.component call the service once and distribute the fields value to search-panel, filters and result component.
Also removed the providers list from filters component which caused the BehaviorSubject not working.
The change in angular.json is just the order of style sheets. For some reason the integration branch I downloaded had problem displaying icons. Only after changing the order of style sheets the icons showed up.