Restore GitHub Actions workflow - #56
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Restores and modernizes the GitHub Actions CI workflows for Windows builds (per Issue #53), while removing previously configured Semgrep and CodeQL workflows.
Changes:
- Update Windows CI matrix to include a newer Windows/Visual Studio configuration and drop the older Windows Server 2019 entry.
- Bump Windows workflow actions to newer major versions (e.g.,
actions/checkout@v4,microsoft/setup-msbuild@v2). - Remove legacy code-scanning workflows (Semgrep and CodeQL).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/windows.yml |
Updates Windows CI matrix and action versions for building/testing. |
.github/workflows/semgrep.yml |
Deletes Semgrep workflow. |
.github/workflows/.semgrep.yml |
Deletes Semgrep workflow variant. |
.github/workflows/codeql-analysis.yml |
Deletes CodeQL scanning workflow. |
Comments suppressed due to low confidence (1)
.github/workflows/codeql-analysis.yml:1
- This workflow is being deleted, and there doesn’t appear to be any replacement CodeQL/code-scanning workflow left under
.github/workflows/. If code scanning is still desired/required for this repo, consider keeping CodeQL enabled (or replacing it with an alternative) so security scanning doesn’t silently regress.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
utilForever
marked this pull request as ready for review
March 18, 2026 00:26
There was a problem hiding this comment.
Pull request overview
Restores and modernizes the GitHub Actions CI workflows across Windows, Linux, and macOS, while removing older static analysis workflows and updating some build tooling.
Changes:
- Updated CI workflows to newer action versions, newer OS images/toolchains, and standardized Python setup.
- Adjusted CMake configuration (minimum required version) and fixed/cleaned up coverage CMake targets.
- Removed legacy Semgrep/CodeQL workflow configurations and disabled the SonarCloud workflow by commenting it out.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| Libraries/pybind11 | Updates pybind11 submodule revision. |
| Libraries/doctest | Updates doctest submodule revision. |
| CMakeLists.txt | Raises minimum CMake version requirement. |
| CMake/CodeCoverage.cmake | Fixes/normalizes custom target command invocation and post-build messaging. |
| .github/workflows/windows.yml | Modernizes Windows CI, adds Python setup, updates action versions, adjusts matrix. |
| .github/workflows/ubuntu.yml | Moves Linux CI to Ubuntu 24.04 and newer compiler matrix, adds Python setup. |
| .github/workflows/macos.yml | Updates macOS CI matrix and adds Python setup. |
| .github/workflows/ubuntu-codecov.yml | Updates Codecov workflow, collects lcov output, switches to codecov-action. |
| .github/workflows/ubuntu-sonarcloud.yml | Disables SonarCloud workflow by commenting out its contents. |
| .github/workflows/semgrep.yml | Removes legacy Semgrep workflow. |
| .github/workflows/codeql-analysis.yml | Removes legacy CodeQL workflow. |
| .github/workflows/.semgrep.yml | Removes legacy Semgrep workflow config. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #56 +/- ##
==========================================
+ Coverage 99.43% 99.53% +0.09%
==========================================
Files 8 8
Lines 357 429 +72
Branches 0 56 +56
==========================================
+ Hits 355 427 +72
Misses 2 2 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This revision includes: