Impl'd Send for Document

[Billy-Sheppard]

Will this have any unintended effects? Unsure if this was not implemented for a reason.

[Billy-Sheppard]

Is this repo still maintained?

[Billy-Sheppard]

@utkarshkukreti - is this addition rejected? Fair enough if so, I can close the PR

[utkarshkukreti]

Sorry for not replying earlier, I'm not doing much open source work these days.

This looks incorrect to me - Document embeds node::Raw which embeds StrTendril which is not Send (if it were Send, Document would have been Send automatically, see https://doc.rust-lang.org/nomicon/send-and-sync.html).

Send and Sync are also automatically derived traits. This means that, unlike every other trait, if a type is composed entirely of Send or Sync types, then it is Send or Sync. Almost all primitives are Send and Sync, and as a consequence pretty much all types you'll ever interact with are Send and Sync.

[Billy-Sheppard]

No worries. Is the intention to keep this crate maintained? Would you be interested in letting someone else maintain?

I've got Sync/Send working now, and also updated the dependencies, however unfortunately at the moment they reference git rev's. I have left in comments the highest crates.io versions compatible. I also have a PR I could do to bring the codebase up to current clippy lints.